fix(terms): fixed EmptyCriterion bug with ComplexCriterion

kayak / pypika

PyPika is a python SQL query builder that exposes the full richness of the SQL language using a syntax that reflects the resulting query. PyPika excels at all sorts of SQL queries but is especially useful for data analysis.

http://pypika.readthedocs.io/en/latest/

Apache License 2.0

2.5k stars 295 forks source link

fix(terms): fixed EmptyCriterion bug with ComplexCriterion #732

Closed GeorgiySurkov closed 1 year ago

GeorgiySurkov commented 1 year ago

issue: https://github.com/kayak/pypika/issues/327

AzisK commented 1 year ago

For some reason the CI tests did not run with this PR. Could you update the code with the newest from the master branch?

GeorgiySurkov commented 1 year ago

Yes, of course!

coveralls commented 1 year ago

coverage: 98.43% (+0.007%) from 98.423% when pulling ab62819ac76f94dd76a1caf4d8e6e1fcb91fb8d4 on GeorgiySurkov:master into ea9cc5b222dd9f056d072ceebce25f5980d4c2dd on kayak:master.

AzisK commented 1 year ago

It looks good and I am merging this but version bump will come later