refactor: CI - Githubissues

kayak / pypika

PyPika is a python SQL query builder that exposes the full richness of the SQL language using a syntax that reflects the resulting query. PyPika excels at all sorts of SQL queries but is especially useful for data analysis.

http://pypika.readthedocs.io/en/latest/

Apache License 2.0

2.43k stars 293 forks source link

refactor: CI #752

Closed gavindsouza closed 9 months ago

gavindsouza commented 9 months ago

Changes

Merge GitHub Actions manifests into one for Lint & Unit Tests jobs
Update supported env list to [3.8, 3.9, 3.10, 3.11]
Add Pre-commit File - Run pre-commit install to setup your hooks

Fixes https://github.com/kayak/pypika/issues/748, https://github.com/kayak/pypika/issues/747

AzisK commented 9 months ago

Good job Gavin. Could you also update the checkout Github Action actions/checkout@v1 since there is already v4 out there?

Nevermind, I see you bumped it already

coveralls commented 9 months ago

coverage: 98.423% (+0.002%) from 98.421% when pulling 25a0484c02d637683e37d8b2b01f0f862b4a68ad on gavindsouza:refactor-ci into 30574f997c80851f7e940ad09a63e14a98871dd3 on kayak:master.

gavindsouza commented 9 months ago

Hey @AzisK, is there anything else I can do to help get this merged?

AzisK commented 9 months ago

@gavindsouza it looks good but before that could you look at my last comments about pypy and black target version and tox envlist?

gavindsouza commented 9 months ago

@gavindsouza it looks good but before that could you look at my last comments about pypy and black target version and tox envlist?

I can't find anything regarding those yet to be addressed. (Did you add comments that are in a Pending state? If so, you are yet to submit your review)

Meanwhile, since black is moved to pre-commit, I think removing it from dev-requirements tracking is best.

AzisK commented 9 months ago

@gavindsouza

RE: Meanwhile, since black is moved to pre-commit, I think removing it from dev-requirements tracking is best.

I agree

RE: I can't find anything regarding those yet to be addressed. (Did you add comments that are in a Pending state? If so, you are yet to submit your review)

Yes, they have been in a pending state, sorry about that and thanks for the notice

AzisK commented 9 months ago

Everything looks good, thanks! I will merge the pull request but version bump and release will happen a little bit later. However, this mostly concerns the CI, so I believe the version is not even very important in this case