Fix get_tree_diff for sep - Githubissues

kayjan / bigtree

Tree Implementation and Methods for Python, integrated with list, dictionary, pandas and polars DataFrame.

https://bigtree.readthedocs.io

MIT License

168 stars 13 forks source link

Fix get_tree_diff for sep #308

Closed kayjan closed 1 week ago

kayjan commented 1 week ago

Description

get_tree_diff can now handle

sep that are different from default (as mentioned in https://github.com/kayjan/bigtree/issues/306)
sep that contain forbidden symbols, there will be a fallback sep
sep that is different for tree and other_tree, this will throw error now (might not be backwards compatible)

Testing

Add test cases for all the above

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

[x] I have added a descriptive title for this pull request.
[x] I have followed the convention and standards, and my code is checked for style and correctness.
[x] I have added test cases, and unit tests pass with 100% code coverage.
[x] I have updated the documentation and code docstrings.

Checklist (for reviewer)

[x] I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
[x] I will ensure this change is captured in the CHANGELOG.md file.

github-actions[bot] commented 1 week ago

Package	Line Rate	Branch Rate	Complexity	Health
bigtree	100%	100%	0	✔
bigtree.binarytree	100%	100%	0	✔
bigtree.dag	100%	100%	0	✔
bigtree.node	100%	100%	0	✔
bigtree.tree	100%	100%	0	✔
bigtree.utils	100%	100%	0	✔
Summary	100% (2356 / 2356)	100% (994 / 994)	0	✔