kaylai / VESIcal

A generalized python library for calculating and plotting various things related to mixed volatile (H2O-CO2) solubility in silicate melts.
MIT License
26 stars 9 forks source link

Inconsistent acceptance of variable types for X_fluid #155

Open simonwmatthews opened 2 years ago

simonwmatthews commented 2 years ago

Calculations with magmasat will only accept an int or float for X_fluid, whereas the other methods will also accept a pandas.Series with CO2 and H2O as the keys. Obviously this is redundant at the moment, but is there so that further volatile species can be added in the future without changing the behaviour of the code. Whilst magmasat won't include more species, it would be good to have the same behaviour supported. We should also allow the code to accept a dict for X_fluid.