kaylai / VESIcal

A generalized python library for calculating and plotting various things related to mixed volatile (H2O-CO2) solubility in silicate melts.
MIT License
26 stars 9 forks source link

Verbose argument doesn't propagate in BatchFile calculations #159

Closed simonwmatthews closed 2 years ago

simonwmatthews commented 2 years ago

If someone is calculating the equilibrium fluid composition at a specified pressure, the BatchFile method won't return mass of fluid etc in the DataFrame. Probably the best thing to do is to run calculations in verbose mode always when using BatchFiles. I also think the models I coded won't supply this information at all. I should be able to find time to fix this soon, but I'm tagging you Kayla just so you're aware, or maybe there's something I've missed!

kaylai commented 2 years ago

Fixed! At least for calculate_equilibrium_fluid_composition(). This is updated in v1.0.3, commit 4eaa1dfd05a70b19e98c27ec718b4852e56904bd