kayleecodes1 / cas-authentication

A CAS authentication library designed to be used as middleware for an Express server.
MIT License
73 stars 77 forks source link

better assign of cas port #25

Open nstylianides opened 4 years ago

nstylianides commented 4 years ago

A. CAS Server Port configuration I suggest the following change at line 151

change: this.cas_port = parsed_cas_url.protocol === 'http:' ? 80 : 443;

to:

this.cas_port = (parsed_cas_url.port!=null)?parsed_cas_url.port:(parsed_cas_url.protocol === 'http:' ? 80 : 443);

B. REST API I suggest to enhance this package to support also the REST API. How can we push code on github and npm?