kaystrobach / TYPO3.dyncss

Dyncss base extension - Donate if you like it http://donate.kay-strobach.de/
http://forge.typo3.org/projects/extension-dyncss
GNU General Public License v2.0
9 stars 27 forks source link

Context-sensitive file cache not working in TYPO3 8 LTS #50

Open Freshmeat-ch opened 7 years ago

Freshmeat-ch commented 7 years ago

Under TYPO3 8 LTS and Development-context the parser should generate a new file if include-files where changed. This worked in TYPO3 7 LTS (maybe a unknown effect because i think the commit https://github.com/kaystrobach/TYPO3.dyncss/pull/39 breaks this behaviour on LTS 7 too).

Currently I added an additional Development-Mode check in Classes/Parser/AbstractParser.php:289 to disable caching. if (@filemtime($outputFilename) < @filemtime($inputFilename) || $this->_checkIfCompileNeeded($inputFilename) || ApplicationContext::isDevelopmentModeActive()) {

kaystrobach commented 7 years ago

Please open a PR then i will review and check it this week.

Thank you

Von meinem iPhone gesendet

Am 01.05.2017 um 14:42 schrieb Freshmeat-ch notifications@github.com:

Under TYPO3 8 LTS and Development-context the parser should generate a new file if include-files where changed. This worked in TYPO3 7 LTS (maybe a unknown effect because i think the commit https://github.com/kaystrobach/TYPO3.dyncss/pull/39 breaks this behaviour on LTS 7 too).

Currently I added an additional Development-Mode check in line 289 to disable caching. if (@filemtime($outputFilename) < @filemtime($inputFilename) || $this->_checkIfCompileNeeded($inputFilename) || ApplicationContext::isDevelopmentModeActive()) {

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

kaystrobach commented 5 years ago

i think this was fixed with the latest version from 6 month ago, if not, please reopen.

dbruening commented 5 years ago

Don't works in TYPO3 8.7.22 with the current files form github.

tdeuling commented 5 years ago

I can confirm that this issue still remains.

kaystrobach commented 5 years ago

We added some more agressive caching to dyncss before the 8.x release, maybe it fails because of this.

How do you setup your context?

tdeuling commented 5 years ago

We have tried this with activated Dev-Mode in installtool and additionally SetEnv TYPO3_CONTEXT Development in .htaccess file. The backend info section displays "Application Context Development".