search

kaystrobach / TYPO3.dyncss

Dyncss base extension - Donate if you like it http://donate.kay-strobach.de/
http://forge.typo3.org/projects/extension-dyncss
GNU General Public License v2.0
9 stars 28 forks source link

Use of Constant TYPO3_cliMode #58

Closed woodyc79 closed 6 years ago

woodyc79 commented 6 years ago

Use Constant TYPO3_cliMode only in TYPO3 versions lower 8

kaystrobach commented 6 years ago

@woodyc79 and @CDRO can you please also verify that

CDRO commented 6 years ago

I get the $isCliRequest = false leads to an error, since it is indeed not used anywhere, but the static request to GeneralUtilty cannot be avoided I guess :-)

kaystrobach commented 6 years ago

needs testing and some refactoring later ... static calls should be avoided

kaystrobach commented 6 years ago

this extension definitely needs some unit tests 😄

CDRO commented 6 years ago

That's probably true, but I think that in the meantime you should ignore the PR Quality Review concerning the static call, at the moment this is best practice in TYPO3, so I don't see much that we could do about it :-)

kaystrobach commented 6 years ago

If you verify, that it works as expected, i will merge it.

CDRO commented 6 years ago

This solved the issues on TYPO3 8, I've sadly got no 7.6 with dyncss laying around to test it though.

kaystrobach commented 6 years ago

tests on 7.6 are green.