kaystrobach / TYPO3.dyncss_less

Dyncss Less Adapter
http://forge.typo3.org/projects/extension-dyncss
5 stars 14 forks source link

Replace leafo/lessphp with oyejorge/less.php? #5

Closed fritjofbohm closed 10 years ago

fritjofbohm commented 10 years ago

Do you have any plans to replace lessphp with less.php? lessphp seems to be quite dormant at the moment, while less.php is under active development.

kaystrobach commented 10 years ago

not yet, but i can build an additional adapter, as this should be quite easy :)

I assume, you mean this one? http://lessphp.gpeasy.com/

fritjofbohm commented 10 years ago

Exactly, see also the GitHub repo https://github.com/oyejorge/less.php . less.php offers a drop-in replacement to leafo/lessphp, so that you wouldn't need to change your code. My motivation to ask for the replacement is that less.php offers Less source maps, which lessphp doesn't.

kaystrobach commented 10 years ago

evt. hilft dir der branch hier, ist aber derzeit nur ein test ... ich habe es noch nicht getestet, nur erstmal den code angepasst.

https://github.com/kaystrobach/TYPO3.dyncss_less/archive/TestingLess.php.zip

fritjofbohm commented 10 years ago

Das sieht sehr gut aus. Eine Anpassung musste ich aber an den Import-Dirs machen, sonst wurden bei mir die Imports nicht gefunden:

protected function _compileFile($inputFilename, $preparedFilename, $outputFilename, $cacheFilename) {
        try {
            $this->parser->setImportDirs(
                array(
                    dirname($inputFilename) => dirname($inputFilename),
                    PATH_site => PATH_site
                )
            );
            $this->parser->parseFile($preparedFilename);

            return $this->parser->getCss();
        } catch(Exception $e) {
            return $e;
        }
    }
kaystrobach commented 10 years ago

ich habe die zeilen geändert

fritjofbohm commented 10 years ago

Coole Sache. Wenn ich es hinbekomme, schicke ich dir morgen einen pull request, damit die Source Map-Funktion an enableDebugMode von dyncss gebunden ist.

kaystrobach commented 10 years ago

so?

fritjofbohm commented 10 years ago

Super! Bin gespannt auf die weitere Entwicklung. Deine Extension ist großartig!

kaystrobach commented 10 years ago

merged with master branch ...

kaystrobach commented 10 years ago

ter release will be done later ...