review for ppc - Githubissues

kayws426 / embox

Automatically exported from code.google.com/p/embox

0 stars 1 forks source link

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

hi. today i finished work on porting embox on powerpc, after that i merged my 
branch into trunk (r7597). i wait for your ratings

Original issue reported on code.google.com by ki.stfu on 22 Nov 2012 at 12:40

GoogleCodeExporter commented 9 years ago

Why do you ask for a review AFTER you have already merged your changes into the 
trunk?

Original comment by Eldar.Abusalimov on 22 Nov 2012 at 8:37

GoogleCodeExporter commented 9 years ago

because now you can see into what files was modified. yes, it's not correct way 
to do this, next time will not merge with trunk before review

Original comment by ki.stfu on 22 Nov 2012 at 9:01

GoogleCodeExporter commented 9 years ago

I could see the whole changeset by comparing branch with the trunk on my local 
machine. OK, I will take a look soon.

Original comment by Eldar.Abusalimov on 22 Nov 2012 at 9:28

GoogleCodeExporter commented 9 years ago

Original comment by ki.stfu on 4 Dec 2012 at 2:51