thread alloc sets incorrect stack

[GoogleCodeExporter]

src/kernel/thread/core.c:512

t->stack = &block->stack + sizeof(struct thread);

is incorrect, since block->start is char[STACK_SZ]. That leads to t->stack 
points far from real stack. Suggested fix is 

t->stack = (void *) &block->stack + sizeof(struct thread);

I'm not fixing myself because that's seems to strange to work earlier.

Original issue reported on code.google.com by drakon.m...@gmail.com on 19 Mar 2013 at 5:08

[GoogleCodeExporter]

More proper fix is to remove an ampersand:
t->stack = block->stack + sizeof(struct thread);

Another solution is to add a flex array member to the end of thread struct:

struct thread {
    ...
    char stack[];
}

Antonishko, feel free to fix it yourself.

Original comment by Eldar.Abusalimov on 19 Mar 2013 at 5:21

• Changed state: Accepted

[GoogleCodeExporter]

How did it work before???

Original comment by iantonishko on 19 Mar 2013 at 7:58

• Changed state: Fixed