search

kayws426 / embox

Automatically exported from code.google.com/p/embox
0 stars 1 forks source link

err.h conflict #636

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. look at src/include/err.h
2. look at `man err'

What is the expected output? What do you see instead?
same header name, same function name, but signatures and semantics are totally 
different

Please use labels and text to provide additional information.

Original issue reported on code.google.com by drakon.m...@gmail.com on 20 Aug 2013 at 11:52

GoogleCodeExporter commented 9 years ago 
CONFORMING TO
       These functions are nonstandard BSD extensions.

Original comment by Eldar.Abusalimov on 20 Aug 2013 at 11:54

GoogleCodeExporter commented 9 years ago 
Nevertheless, it is bad practice to give header/function the name which is 
known to be already occupied even by nonstandard thing.
There are pretty much other better suited names.

Original comment by fsul...@gmail.com on 20 Aug 2013 at 12:05

GoogleCodeExporter commented 9 years ago 
> There are pretty much other better suited names.
OK, suggest some, please.

Original comment by Eldar.Abusalimov on 20 Aug 2013 at 12:30

GoogleCodeExporter commented 9 years ago 
No problem, les's start by considering to move it to <embox/err.h>.
I would provide more suitable naming if I knew what this function does and what 
it exists for. Without a doubt, it's signature "int err(void *res)" is self 
describing...

Original comment by fsul...@gmail.com on 20 Aug 2013 at 12:37

GoogleCodeExporter commented 9 years ago 
Considering what it does I would suggest to name it ptr2err.

Original comment by fsul...@gmail.com on 20 Aug 2013 at 12:44

GoogleCodeExporter commented 9 years ago 
I'd suggest e2p and p2e

Original comment by drakon.m...@gmail.com on 19 Mar 2015 at 1:51

GoogleCodeExporter commented 9 years ago 
err.h moved to util/err.h

About err signature I suggest 'errptr'

Original comment by Anton.Bo...@gmail.com on 19 Mar 2015 at 1:59