search

kaz-yos / eval-in-repl

Consistent ESS-like eval interface for various REPLs
174 stars 27 forks source link

Make require js3-mode conditionally #40

Closed stardiviner closed 4 years ago

stardiviner commented 4 years ago

I use use-package to load eval-in-repl. Seems eval-in-repl require js3-mode explicitly. I think this should be conditionally by using if condition (featurep 'js3-mode) to detect.

Here is the error I got:

Error (use-package): eval-in-repl/:config: Cannot open load file: No such file or directory, js3-mode
stardiviner commented 4 years ago

Here is a PR fix this: https://github.com/kaz-yos/eval-in-repl/pull/41