Fix Hmisc continuous variables treated as factors.

kaz-yos / tableone

R package to create "Table 1", description of baseline characteristics with or without propensity score weighting

https://cran.r-project.org/web/packages/tableone/index.html

218 stars 41 forks source link

Fix Hmisc continuous variables treated as factors. #66

Closed ndevln closed 4 years ago

ndevln commented 4 years ago

Hi @kaz-yos,

the fix from #64 worked. But while testing variables labelled with labelled or haven I did run into another problem. If you add value labels to numeric variables the class changes to double. I'm quite surprised this was not a problem earlier. I extended an existing test to check for this.

Fixes #57, fixes #64.

Greetings, Alex

PS: I went through the issues. Can #21, #43 and #61 be closed?

kaz-yos commented 4 years ago

Thank you so much for figuring this out and solving it! The changes look good to me.