kazaneza / calculator

MIT License
1 stars 0 forks source link

I'm Looking for a Code Review of My Functional Component Implementation for Math Magicians #8

Open kazaneza opened 1 year ago

kazaneza commented 1 year ago

I would like to request a code review of my implementation for a basic calculator app using functional components. Although the implementation is already completed, I am seeking feedback and suggestions for improvement.

Here is the link https://github.com/kazaneza/calculator/tree/events

If possible, I have a few specific questions:

I would be grateful for any assistance you can provide. Thank you.

HAMMAS-SALEEM commented 1 year ago

Required Changes :recycle:

almost-there

Hey @amexabee :wave:

Highlights :1st_place_medal:

:heavy_check_mark: Descriptive Issue Title :heavy_check_mark: Following Requirements :heavy_check_mark: Following Functional Programming

Good job on implementing some of the requirements, there are some issues that you still need to work on to go to the next project but you are almost there! :blush:

Optional

All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.

Cheers and Happy coding! :clap: :clap: :clap:

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Changes Required

  1. How we can use functional components in react?
  2. What are the changes we face when we use functional components instead of class components?

Hint: You can see this project to get an idea of how to answer these questions but kindly use your own words because I know you are smart enough :muscle:

Note: I know you have asked questions and there is no harm in asking questions I am really interested in discussing with you my dear brother :blush: We can discuss your questions in slack if you don't mind :+1: