search

kazaneza / calculator

MIT License
1 stars 0 forks source link

I'm Looking for a Code Review of My Functional Component Implementation for Math Magician #9

Open kazaneza opened 1 year ago

kazaneza commented 1 year ago

In this issue page, I explained how to use functional components in React and the changes we need to make when using them instead of class components. Functional components are simpler to define and don't have state or lifecycle methods. We can use hooks for state and lifecycle methods, access props directly or through destructuring, and use arrow functions for event handlers.

Although the implementation is already completed, I am seeking feedback and suggestions for improvement.

Here is the link https://github.com/kazaneza/calculator/tree/events

If possible, I have a few specific questions:

Is my use of functional components efficient and suitable for the task? Have I correctly utilized state and props?

I would be grateful for any assistance you can provide. Thank you.

rotimiazeez commented 1 year ago

Hi @kazaneza 👏🏽,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlight

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code. Some of them were simply missed by the previous reviewer, and addressing them will improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Remember to tag me(@rotimiazeez) in your question so I can receive the notification.

As described in the Code reviews limits policy, you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

levy002 commented 1 year ago

Hello @kazaneza

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Status: APPROVED :fire: :fire:

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.