search

kazauwa / ansible-role-headscale

Ansible role for Headscale
MIT License
29 stars 11 forks source link

Fix for for issue #5 #6

Closed justin-p closed 8 months ago

justin-p commented 8 months ago

Fix for for issue #5

kazauwa commented 8 months ago

Hi! Thank you so much for reporting this bug and finding time to fix it! All these changes look good to me. However, could you replace ansible.builtin.meta and ansible.builtin.systemd_service with meta and systemd_service, respectively?

The reason is that FQCNs may break compatibility with Ansible 2.9. I want to release this fix as a patch version since this bug prevents the first installation from running successfully.

That said, this role deserves some love, and I owe it an upgrade to support modern Ansible versions. However, it'd be a breaking change that deserves a major version bump.

justin-p commented 8 months ago

Hia @kazauwa,

No problem my dude. It takes less time to fix this role then build it from scratch myself ;) Reverted those changes back to non-FQCN.

kazauwa commented 8 months ago

Thank you very much!