kazazor / git-pre-commit

A pre-commit hook that ignores all the unstagged changes while performing the pre-commit command you wrote (Using Shell, Gulp, Grunt etc..)
https://www.npmjs.com/package/git-pre-commit
MIT License
18 stars 5 forks source link

Source tree on Ubuntu (14.04.1 LTS Parallels) ignores the pre-commit hook #9

Open kazazor opened 8 years ago

kazazor commented 8 years ago

Tested on Ubuntu 14.04.1 (LTS version at the time of the test) using Parallels for OSX.

The git pre-commit hook is being ignored and the code is being committed even that the pre-commit hook should have failed it (on the terminal it works fine on the same scenario)

kazazor commented 8 years ago

The test was made using SSHFS to the guest Ubuntu on the OSX machine (Using Parallels).

It could be that for some reason the error occurs due to the use of SSHFS.

Need to be tested on an Ubuntu machine without SSHFS to verify the issue.

kazazor commented 8 years ago

Well apparently I didn't perform the test correctly. I was testing it on SourceTree on the host OSX and not on the Ubuntu Parallels machine. So I'm removing the bug label and returning it to question until a better test will be performed.