logging return value of writev(2)

[syohex]

There is similar part at https://github.com/karupanerura/Gazelle/blob/logging-writev-rv/lib/Plack/Handler/Gazelle.xs#L1040

And return value of writev in error case is always -1(See manpage). So it makes little sense. I suppose errno or strerror(strerror_r) is better than return value.

[karupanerura]

And return value of writev in error case is always -1

Yes. I know that. But, this case is if ( rv <= 0 ). So I want to know the rv value is zero or not.

[syohex]

Ah sorry, I missed.

[karupanerura]

There is similar part at https://github.com/karupanerura/Gazelle/blob/logging-writev-rv/lib/Plack/Handler/Gazelle.xs#L1040

Thank you for your notice.

[karupanerura]

NOTE: Tests failed at travis-ci. but it works. Are travis-ci broekn? (maybe) https://travis-ci.org/kazeburo/Gazelle/jobs/113327668

[syohex]

There were network issue(sometimes error happens :-() and not related to this change. Please retry tests by git commit --amend(no changes), git push -f or asking repository owner.

BTW: it is better to set sudo: false in .travis.yml for faster CI.

[karupanerura]

@kazeburo could you merge it?

[kazeburo]

https://travis-ci.org/kazeburo/Gazelle/jobs/113327667 test passed

[karupanerura]

thank you!