search

kazeburo / Plack-Middleware-ServerStatus-Lite

Plack-Middleware-ServerStatus-Lite
Other
26 stars 11 forks source link

I use skip_ps_command => 1 #10

Closed karenetheridge closed 11 years ago

karenetheridge commented 11 years ago

re Plack-Middleware-ServerStatus-Lite-0.14-TRIAL and removing skip_ps_command -- I use this option. The only time it would be useful to call ps is when not every PSGI worker has processed a request yet - otherwise, there will be an entry in the status file for it, and ps is unnecessary. On busy production systems, where I have haproxy hitting '/server-status' every few seconds to ensure that a server is up, removing the ps call saves a lot of resources.

Please keep this option (or, remove the use of ps entirely - I'd be fine with that too.) :)

kazeburo commented 11 years ago

I understand your use case, I'll keep skip_ps_command next version.

But I have one question. Why do you use "/sever-status" as healthcheck uri? There should be a URI that uses less resources.

karenetheridge commented 11 years ago

Yes, there should - I should write one :)

karenetheridge commented 11 years ago

http://metacpan.org/module/Plack::Middleware::ServerStatus::Tiny now exists.

I'm now totally cool with you removing skip_ps_command :)

kazeburo commented 11 years ago

released version 0.16 with skip_ps_command