kazeburo / Plack-Middleware-ServerStatus-Lite

Plack-Middleware-ServerStatus-Lite
Other
26 stars 11 forks source link

Docs and implementation don't match wrt "allow" option #16

Open lestrrat opened 9 years ago

lestrrat commented 9 years ago

https://github.com/kazeburo/Plack-Middleware-ServerStatus-Lite/blob/master/lib/Plack/Middleware/ServerStatus/Lite.pm#L47

says if you don't specify the allow parameter, you can access the status page from anywhere, but the implementation actually prohibits access from anywhere if you don't specify the allow parameter

https://github.com/kazeburo/Plack-Middleware-ServerStatus-Lite/blob/master/lib/Plack/Middleware/ServerStatus/Lite.pm#L255 https://github.com/kazeburo/Plack-Middleware-ServerStatus-Lite/blob/master/lib/Plack/Middleware/ServerStatus/Lite.pm#L258

These should actually read return 1 unless $self->{__cidr4}