Closed astj closed 8 years ago
Before 0.35, Uptime parameter from response of {path}?json was a JSON string. (its value was quoted by ") But at 0.35, It (maybe unexpectedly) changed to a JSON number, caused by commit 1fd7e6b0dfd05a16630a8ba0d25e367efb52541f.
Uptime
{path}?json
"
In pre-0.35, $self->{uptime} was flagged as string by string interpolation at https://github.com/kazeburo/Plack-Middleware-ServerStatus-Lite/pull/18/files#diff-1df032baeeed2a3067f85e5d3b0d565dR158 . But 1fd7e6b0dfd05a16630a8ba0d25e367efb52541f removed the interpolation, so JSON::encode_json converts $stats{Uptime} = $self->{uptime} to a JSON number.
$self->{uptime}
$stats{Uptime} = $self->{uptime}
The change at 0.35 breaks some parser like mackerel-agent-plugin, which expects it's a JSON string. So I'd like to change it back to JSON String.
mackerel-agent-plugin
Thank you
kazeburo
commented
8 years ago
Before 0.35,
Uptimeparameter from response of{path}?jsonwas a JSON string. (its value was quoted by") But at 0.35, It (maybe unexpectedly) changed to a JSON number, caused by commit 1fd7e6b0dfd05a16630a8ba0d25e367efb52541f.In pre-0.35,
$self->{uptime}was flagged as string by string interpolation at https://github.com/kazeburo/Plack-Middleware-ServerStatus-Lite/pull/18/files#diff-1df032baeeed2a3067f85e5d3b0d565dR158 . But 1fd7e6b0dfd05a16630a8ba0d25e367efb52541f removed the interpolation, so JSON::encode_json converts$stats{Uptime} = $self->{uptime}to a JSON number.The change at 0.35 breaks some parser like
mackerel-agent-plugin, which expects it's a JSON string. So I'd like to change it back to JSON String.