kazewong / TurboPE

MIT License
5 stars 2 forks source link

Referee report from ApJ #4

Closed kazewong closed 1 year ago

kazewong commented 1 year ago

Reviewer:

Firstly, I would like to say what an awesome result this is, and what a pleasure it was to read the manuscript! The authors demonstrate end-to-end parameter estimation on CBC gravitational-wave signals on the order of a minute. Their approach is novel, incorporating gradient-based MCMC with normalizing flows for both fast and efficient sampling. While other groups have used similar ideas, one of the key ways in which this work differs is that it does not require pre-training of the normalizing flow network.

I have a few relatively minor points which I would like to see addressed.


Data Editor's review : One of our data editors has reviewed your initial manuscript submission and has the following suggestion(s) to help improve the data, software citation and/or overall content. Please treat this as you would a reviewer's comments and respond accordingly in your report to the science editor. Questions can be sent directly to the data editors at data-editors@aas.org.

\software{scipy (Virtanen et al. 2020), flowMC (Wong et al. 2022; Gabrié et al. 2022), ripple package (Edwards et al. in prep.), pBilby (Smith et al. 645 2020)}

Please pay close attention to the author list for the DOI deposit and that both the GitHub and DOI deposit have valid and consistent software licenses.

[1] https://journals.aas.org/news/policy-statement-on-software/

[2] https://github.com/AASJournals/Tutorials/tree/master/Repositories

[3] https://guides.github.com/activities/citable-code/

[4] https://journals.aas.org/aastexguide/#softwareandthirdparty

https://github.com/showyourwork/showyourwork/pull/256

kazewong commented 1 year ago

@maxisi @tedwards2412 Here is the itemized list of points in our referee report.

kazewong commented 1 year ago

@maxisi @tedwards2412 Finally I have addressed most of the comments from the referee report. The changes are highlighed in red in the script. Please have a look and let me know when it is ready to be shipped back to ApJ!