Update the run manager - Githubissues

ThibeauWouters commented 1 month ago

Here is some things we might want to add to the run manager:

[x] Compute the SNR and save it somewhere.
[ ] Maybe add support for an SNR threshold, to skip injections below this threshold. See this example script
[ ] Add support to randomly sample injection parameters from the given prior ranges if no injection parameters are given.
[x] Plotting functionalities (see #107 for work in progress)
[ ] Add functionality to save everything in the runmanager: hyperparameters, save the output chains separately.
[ ] Add flexible functionality for loading from other RunManagers, e.g., load the injection parameters of a previous run in case the user wants to play around with hyperparameters on a specific injection
[ ] Add command line functionalities (see #18 as well)
[ ] Check how to handle real GW events, load data, preprocess it et cetera.
[ ] Add dedicated examples of the runmanager
[x] Add functionality to for doing multiple event runs in a batch (see #145 )

zipengwang98 commented 1 month ago

pushed a new commit that stores SNR

ThibeauWouters commented 1 month ago

@zipengwang98 where exactly? I don't see it

thomasckng commented 1 month ago

I think he meant this commit

kazewong / jim