The Jacobian determinant for transformation should take absolute value

kazewong / jim

Gravitational-wave data analysis tools in Jax

MIT License

54 stars 19 forks source link

The Jacobian determinant for transformation should take absolute value #126

Closed xuyuon closed 1 month ago

xuyuon commented 2 months ago

Currently, JIM computes the density change in the parameter space due to transformation by calculating the Jacobian determinant. The absolute value of the Jacobian determinant should be used; otherwise, feeding it into the calculation of the log Jacobian determinant may result in nan values.

thomasckng commented 1 month ago

Mentioned and fixed in #133

xuyuon commented 1 month ago

The fix is moved to #137