search

kazewong / jim

Gravitational-wave data analysis tools in Jax
MIT License
54 stars 19 forks source link

Update initial position sampling in maximize_likelihood #153

Closed thomasckng closed 2 weeks ago

thomasckng commented 3 weeks ago

Use the same code in #152 for maximize_likelihood.

thomasckng commented 3 weeks ago

@kazewong Other parts of this function require changes as well. I am not sure how to do that, do you mind taking a look later?

kazewong commented 3 weeks ago

I am not sure what you are trying to do here. The original PR has already been merged.

thomasckng commented 3 weeks ago

The function I changed is in likelihood.py. It has the same code structure as the code you merged in #152. Maybe I can change the base to jim_dev. It might be more obvious.

thomasckng commented 3 weeks ago

The loops before and after the code I modified still need some work.