Branch per XC Release

[ajsuth]

We may have to address compatibility between releases. While we may be able to use the same code base for multiple versions, we should still differentiate and support individual releases.

Not sure if the best way to accomplish this is via a develop branch per release.

It would also be good to establish the earliest release we want to support.

FYI @kazimnami, @raytran-sitecore

[raytran-sitecore]

Unless the the API is changing I'm not seeing the benefit of having different branches per release.

How about one branch per major release e.g. 8.2.1, 9.0.x and 9.1

Although there were some breaking changes in 9.0.1 -> 9.0.2 so not sure how far we would get with this approach.

[ajsuth]

@raytran-sitecore, this was to manage version references per XC release, however @kazimnami has proposed that there may be a way of applying conditional statements inside the xproj files to specify the reference versions.

Re: breaking changes in 9.0.1 -> 9.0.2, the promotion related code across plugins has been largely untouched since 8.2.1 so this repo should be compatible for all XC versions prior to 9.1. (Will need to evaluate 9.1 codebase upon release.

[ajsuth]

Hi @kazimnami, in 53c7cf7d02f9b02eee94ebbe933efe023e6a8542 I noticed we've used Condition=" '$(Configuration)'!='Debug 9.1' " and Condition=" '$(Configuration)'=='Debug 9.1' ". Understanding this is just a first pass, are we planning on creating a Debug configuration for each XC release? i.e. 9.0.1, 9.0.2, etc.

[kazimnami]

We can do. But I was thinking we support the current version -1 and +1 if we have access.

So what I have setup is debug is current version 9.0.2 and +1 is 9.1

Thoughts?

On Wed, 3 Apr 2019 at 10:32 am, Andrew Sutherland notifications@github.com wrote:

Hi @kazimnami https://github.com/kazimnami, in 53c7cf7 https://github.com/kazimnami/Sitecore.Commerce.Promotions/commit/53c7cf7d02f9b02eee94ebbe933efe023e6a8542 I noticed we've used Condition=" '$(Configuration)'!='Debug 9.1' " and Condition=" '$(Configuration)'=='Debug 9.1' ". Understanding this is just a first pass, are we planning on creating a Debug configuration for each XC release? i.e. 9.0.1, 9.0.2, etc.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kazimnami/Sitecore.Commerce.Promotions/issues/31#issuecomment-479254306, or mute the thread https://github.com/notifications/unsubscribe-auth/AOYbJDzxFB4t3uDzWTGe3JxPY0Ice2c9ks5vc-iZgaJpZM4cFr-9 .

[ajsuth]

Happy with this as we tend to push to upgrade to latest version.

Was just a little confused as we skipped 9.0.3 (my current local)