kazmiya / dokuwiki-plugin-editsections2

A rewritten version of Ben Coburn's "Edit Section Reorganizer Plugin" for DokuWiki
GNU General Public License v2.0
3 stars 3 forks source link

Edit buttons in the wrong places #5

Open DungeonCaster opened 10 years ago

DungeonCaster commented 10 years ago

Buttons are showing up in the wrong places and sometimes not showing up at all. I have some sample wikitext files that demonstrate the problem (see links below).

Here is how to recreate the issue:

1) Start with a standard (2014-05-05 "Ponder Stibbons") DW install and use the bundled DokuWiki Template.

2) Make sure the following plugins are installed and active:

3) Create a page [[dummytable]]. Paste the wikitext from here: https://gist.github.com/DungeonCaster/ecf587a1070953dd0f58#file-dummytable1

4) Create a page [[dummytext]]. Paste the wikitext from here: https://gist.github.com/DungeonCaster/ecf587a1070953dd0f58#file-dummytext1

Now when you look at the dummytext page you will see the following errors:

  1. Edit button for "Step 2" is missing.
  2. Edit button beside "Step 2" points to "Special Notes".
  3. Edit button beside "Variant Policy" points to "Configuration Table".
  4. Edit button inside "Configuration Table" points to "Step 3".
  5. Edit button below "Step 3" points to "Variant Policy".

If you disable the editsections2 plugin all edit buttons are where they should be.

~DC

mat-m commented 9 years ago

About points 1 & 2 : The WRAP plugin forbids edit button inside themselves, which is triggered by your "Special Notes" block. (function 'handle_secedit_button' in action.php of wrap plugin). It also has a section ending when you put a header in a wrap: "syntax/closesection.php"

i don't know how the include plugin handles section edit, but your 3/4/5 may be related to that (and the fact that the include may be parsed before the other blocks.