placing mew-mode-line-format in the end of mode-line-format

kazu-yamamoto / Mew

Messaging in the Emacs World

http://www.mew.org/

Other

191 stars 51 forks source link

placing mew-mode-line-format in the end of mode-line-format #185

Closed kazu-yamamoto closed 1 year ago

kazu-yamamoto commented 1 year ago

The lock icon has not been displayed since Emacs 26.1. This is because "%p" is replaced with mode-line-percent-position in mode-line-position.

First, we supports Emacs 26.1 or later. So, let's remove the code assuming "%p". Second, to make things simple, let's put mew-mode-line-format in the end of mode-line-format.

tats commented 1 year ago

Also, I've noticed displaying the lock icon fails when mew-ssl-default is 'native. See https://github.com/kazu-yamamoto/Mew/pull/186

kazu-yamamoto commented 1 year ago

@tats I think all issues have been resolved.

tats commented 1 year ago

display the lock for 'native

mew-imap-secure-p(), mew-nntp-secure-p() and mew-pop-secure-p() should be updated for 'native to display the lock icon when "Auth'ing", "Checking", "Refiling", etc. See https://github.com/kazu-yamamoto/Mew/pull/186

kazu-yamamoto commented 1 year ago

Drop 43d9a484c23e232d0d30f6a948bea67b748a07e2
Merge this PR
Then merge #186

Is this procedure OK for you?

tats commented 1 year ago

Yes, please go ahead.