kazu-yamamoto / http2

HTTP/2.0 library including HPACK
BSD 3-Clause "New" or "Revised" License
84 stars 22 forks source link

Releasing a new version #134

Closed kazu-yamamoto closed 2 months ago

kazu-yamamoto commented 2 months ago

@edsko @FinleyMcIlwaine To release a new version, we should agree with/check:

FinleyMcIlwaine commented 2 months ago

I think the change in behavior is enough to warrant a bump to 5.3.0. I am not sure yet whether our throughput has been affected. Once I determine what is going on with the empty data frames in our benchmark I will be able to do throughput tests.

As I'm debugging that benchmark, I am still seeing these kinds of window updates in wireshark:

Screenshot 2024-07-11 at 3 43 57 PM

I believe this shows three packets holding six consecutive window updates for the same stream, one being a 9 byte increment, and the rest varying in size from 4069 bytes to 36783 bytes. Does this look like expected behavior? Either way, the small window updates doesn't seem like big enough deal to hold up this release.

Thanks for looping us in @kazu-yamamoto!

kazu-yamamoto commented 2 months ago

The version has bumped to 5.3.0 on the main branch.

The behavior of window update is not what I expect. I should dig it.

kazu-yamamoto commented 2 months ago

Now I can reproduce the window issue. Let me consider how to fix it.

FinleyMcIlwaine commented 2 months ago

@kazu-yamamoto We have submitted some patches that fix the empty data frames we were seeing. It would be ideal if those patches were included in the next releases of http2 and http-semantics. If those are in, I think we are ready for a release.

kazu-yamamoto commented 2 months ago

@edsko @FinleyMcIlwaine I'm going to release the following packages:

Any objections?

I would like to release network-control when the small window update is fixed.

FinleyMcIlwaine commented 2 months ago

@kazu-yamamoto Looks good to us!

kazu-yamamoto commented 2 months ago

The four packages above have been released. Thank you for your contribution!