Push promises can't have a streamed response

kazu-yamamoto / http2

HTTP/2.0 library including HPACK

BSD 3-Clause "New" or "Revised" License

86 stars 22 forks source link

Push promises can't have a streamed response #19

Open acastello opened 4 years ago

acastello commented 4 years ago

If you use responseStreaming when building the body of a push promise, the client receives a RSTStreamFrame InternalError (tested with the http2-client-exe package). This is caused by a fromJust in the frameSender function: Push promises with a streamed body are not output with a stream queue so the current implementation just crashes.

kazu-yamamoto commented 4 years ago

@acastello Thank you for pointing out. Could you fix it by yourself and send a PR? I'm busy in this week because of QUIC interop.