Allow TLS config to be supplied to https clients

kazu-yamamoto / http2

HTTP/2.0 library including HPACK

BSD 3-Clause "New" or "Revised" License

86 stars 22 forks source link

Allow TLS config to be supplied to https clients #25

Closed ProofOfKeags closed 3 years ago

ProofOfKeags commented 3 years ago

In many gRPC use cases (which is my primary use for http2), you want to specify additional root CA certificates. Currently Network.HTTP2.Client does not allow this.

It seems like the approach would be to supply the http client with https://hackage.haskell.org/package/tls-1.5.5/docs/Network-TLS.html#t:ClientParams

kazu-yamamoto commented 3 years ago

http2 does not depend on tls. You can pass a TLS connection through Config.

If you want to have a wrapper function like allocTLSConfig, I should consider implementing it.

ProofOfKeags commented 3 years ago

Noted. Thank you.

edsko commented 1 year ago