search

kazu-yamamoto / http2

HTTP/2.0 library including HPACK
BSD 3-Clause "New" or "Revised" License
86 stars 22 forks source link

using Word as the internal representation of window size #64

Closed kazu-yamamoto closed 1 year ago

kazu-yamamoto commented 1 year ago

@epoberezkin This might fix #63.

epoberezkin commented 1 year ago

Excellent - thank you so much - will be testing it today (or maybe tomorrow:)

epoberezkin commented 1 year ago

Alas, it didn't solve the issue yet. It might have improved it, as on one occasion it received several http2 bodies (1-4Mb size each) via different servers, but then it got stuck anyway. It more consistently fails on smaller bodies though (256kb) - not sure if it can give a hint?

I'd keep this change, but there is something else...

Do you by any chance have some device that can run armv7a code? It might be easier to debug if you did...

kazu-yamamoto commented 1 year ago

I understand this is a wrong fix. I will make a new PR soon.

kazu-yamamoto commented 1 year ago

@epoberezkin If you change Network/HTTP2/Frame/Types.hs:maxWindowSize from 2147483647 to 1073741823 in the both sides, is this issue resolved?

epoberezkin commented 1 year ago

It’s harder to test the servers… won’t changing the client be enough? I will try

kazu-yamamoto commented 1 year ago

Closing 'cause this is not a correct fix.