search

kazu-yamamoto / http2

HTTP/2.0 library including HPACK
BSD 3-Clause "New" or "Revised" License
86 stars 22 forks source link

Adding sockaddr #88

Closed kazu-yamamoto closed 1 year ago

kazu-yamamoto commented 1 year ago

My project (DNS over HTTP/2) requires to log a pair of socket addresses.

This provides my SockAddr and peer's SockAddr through Aux to Server. Config has breaking changes. If http2-tls is used, these changes are not visible.

Cc: @edsko @epoberezkin

edsko commented 1 year ago

Thanks for the heads up! I haven't migrated to http2-tls yet, still using my own integration. It's on my list of things to do :)

epoberezkin commented 1 year ago

Found it :) Thanks for the heads up.

The problem is that by the time you have TLS the sockets are well hidden inside backend closures... Could these be Maybe, so they are optional?

We don't plan to move to http-tls as we do custom CA verification and there is another use case for a more precise control of TLS sessions... For now migrated to 4.1.4, but looking at some addressed vulnerability recently it would be great to move to the latest...

kazu-yamamoto commented 1 year ago

If SockAddr is not available, please specify a dummy one (e.g. SockAddrInet 0 0).

epoberezkin commented 1 year ago

yep, that's what I ended iup doing :)

Testing 4.2.2 now

epoberezkin commented 1 year ago

It fixed the problem with the exception in streaming not getting to the call! 🚀

Hopefully it'll fix some of the file sending errors we have

kazu-yamamoto commented 1 year ago

Great!