search

kazu-yamamoto / iproute

IP Routing Table in Haskell
http://www.mew.org/~kazu/proj/iproute/
BSD 3-Clause "New" or "Revised" License
47 stars 28 forks source link

add Foldable and Traversable instances to IPRTable #18

Closed greydot closed 9 years ago

greydot commented 9 years ago

Maybe it is a good idea to drop the internal toList implementation in favor of the one from Data.Foldable?

kazu-yamamoto commented 9 years ago

Would you fix the test first?

greydot commented 9 years ago

Sorry for that. I should add Travis to my account perhaps. Do we need to support GHC 7.4 builds?

kazu-yamamoto commented 9 years ago

My policy is to support three versions of GHC. GHC 7.10 has been released but Travis CI does not provide support for GHC 7.10. So, I would like to support GHC 7.4 at this moment.

What is a technical problem to support GHC 7.4 for this change?

greydot commented 9 years ago

The problem is that Data.Foldable in ghc 7.4 does not provide foldl' (strict foldl) function, which is used in fromList. So, there are several ways to fix this issue A. Drop GHC 7.4 support and wait for 7.10 support in Travis (I hope it won't take long). B. Import foldl' from Data.List. This has to be a qualified import, otherwise we get a name conflict with GHC >=7.6. C. Use the lazy function which GHC 7.4 provides.

kazu-yamamoto commented 9 years ago

OK. Let's drop the support of GHC 7.4. Your pull request has been merged.

kazu-yamamoto commented 9 years ago

Version 1.4.0 has been released.