kazu-yamamoto / logger

A fast logging system for Haskell
159 stars 68 forks source link

Does not compile on Windows with latest version of win32 #110

Closed newmana closed 7 years ago

newmana commented 7 years ago

I get the following error when trying to compile 2.4.6 and 2.4.7: C:...\fast-logger-2.4.7\System\Log\FastLogger\FileIO.hs:25:26: error: Ambiguous occurrence fILE_APPEND_DATA' It could refer to eitherSystem.Win32.File.fILE_APPEND_DATA', imported from System.Win32.File' at System\Log\FastLogger\FileIO.hs:10:1-24 orSystem.Log.FastLogger.FileIO.fILE_APPEND_DATA', defined at System\Log\FastLogger\FileIO.hs:18:1

It looks like this was added to Win32 in June: https://github.com/haskell/win32/commit/84b96632627f758f8af96c340a161b138dae9cde#diff-a99994770dbe04188c1176136aef3d32

Maybe delete the two lines: https://github.com/kazu-yamamoto/logger/blob/fast-logger-2.4.6/fast-logger/System/Log/FastLogger/FileIO.hs#L17

kazu-yamamoto commented 7 years ago

Let's close this.