search

kazu-yamamoto / logger

A fast logging system for Haskell
159 stars 68 forks source link

Add MonadReader instance for NoLoggingT #134

Closed arianvp closed 7 years ago

arianvp commented 7 years ago

It was trivial to add. I have a monad stack that is MonadReader, MonadLogger for which I wanted to write unit tests, however, I discovered this instance was missing.

arianvp commented 7 years ago

Yes will do!

arianvp commented 7 years ago

@snoyberg the @since annotation does not show up in Haddock for instance definitions, unfortunately.

snoyberg commented 7 years ago

Thanks!

arianvp commented 7 years ago

Thanks! Could you also put this version on hackage.haskell.org and stackage soon?

snoyberg commented 7 years ago

Yup, I've just uploaded to Hackage, it'll be on Stackage Nightly hopefully tomorrow.

On Wed, May 3, 2017 at 7:03 PM, Arian van Putten notifications@github.com wrote:

Thanks! Could you also put this version on hackage.haskell.org and stackage soon?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kazu-yamamoto/logger/pull/134#issuecomment-298956698, or mute the thread https://github.com/notifications/unsubscribe-auth/AADBB7c107w4BRe14vMeYGkqmz8kIMa3ks5r2KU_gaJpZM4NONE0 .