Closed YoEight closed 6 years ago
Thanks for the report. I didn't realize until this report that 7.8.4 isn't tested by Travis. I see a few options at this point:
Are you currently using new versions of monad-logger on 7.8.4, or is this an automated test that discovered the incompatibility?
Thanks for the quick response. I don't personally use 7.8.4 anymore. I'm just a maintainer that tries to support as many GHC versions as I can (I started that lib back when 7.8 was around). I think 2
is a reasonable solution. I guess when 8.4 will be released, there would be no reason to support a compiler that old.
It's an automated test that discovered the incompatibility (my CircleCI jobs). I didn't notice the breakage because my Travis CI breaks for six months because of out of memory errors. Those issues lead me to move to CircleCI lately.
I just looked into patching this. If you'd like to send a PR, I'll be happy to review and merge. But this is looking pretty hairy for not enough return. I'm more tempted to tighten the lower bound instead.
Fixed by #153, thanks!
Thanks for cutting a new version that fast!
No problem, thanks for the PR
On Wed, Jan 24, 2018 at 1:33 PM, Yorick Laupa notifications@github.com wrote:
Thanks for cutting a new version that fast!
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kazu-yamamoto/logger/issues/153#issuecomment-360103452, or mute the thread https://github.com/notifications/unsubscribe-auth/AADBB5KCT6EXrVEuAEMVS9vXYpew2KMOks5tNxUTgaJpZM4RmqCX .
Greetings,
If you don't have the time, I might be able to submit a patch later this week.
Thanks for your work.