search

kazu-yamamoto / logger

A fast logging system for Haskell
159 stars 68 forks source link

Fix travis #162

Closed phadej closed 6 years ago

phadej commented 6 years ago

I noticed in #161 that travis isn't reliable, let's see if this turns it into green.

phadej commented 6 years ago

Green!

phadej commented 6 years ago

Cannot test GHC-7.6.3 and GHC-7.4.2 as that requires re-installing bytestring which isn't possible due doctest (which depends on ghc).

snoyberg commented 6 years ago

This is Kazu's repo, but I'm opposed in general to the idea of only testing with new-build.

kazu-yamamoto commented 6 years ago

Since the network package already uses new-build only, I' not nervous about this PR. But I would like to ask motivation of this PR to @phadej. Is this the way to go for Cabal?

phadej commented 6 years ago

Sorry for not responding promptly.

The motivation is that current travis setup is not working, and the PR uses https://github.com/haskell-ci/haskell-ci which is actively maintained travis CI script generator. Previous version used HVR PPA, so does this one. cabal new-build is the way for cabal.

kazu-yamamoto commented 6 years ago

Merged. Thank you. I will fix hspec-discover by myself.

phadej commented 6 years ago

Kazu: How build-tool-depends:hspec-discover bug manifests itself?

Sent from my iPhone

On 4 Apr 2018, at 9.23, Kazu Yamamoto notifications@github.com wrote:

Merged. Thank you. I will fix hspec-discover by myself.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

kazu-yamamoto commented 6 years ago

cabal install hspec-discover instead of build-tool-depends: hspec-discover. See the master branch.