Closed MichaelXavier closed 4 years ago
@kazu-yamamoto Just to be clear, are you suggesting:
A) Keeping the existing internal modules in the Internal
directory and then create an Internal.hs
module above that that imports and reexports them so there's only one internal module to import throughout the code.
or
B) Remove the Internal
directory and merge all of the internal modules into one Internal.hs
?
Personally I'm more in favor of A. Despite those modules being internal, they were presumably broken up originally for a reason, like being easier to reason about and work on, so I don't see why we shouldn't preserve that.
What I said is:
C) Sorry, but rework should start the current master
. Adding a Internal.hs
file which imports necessary stuffs and exports them. And add it to exposed-module:
in the cabal file.
Please refer to Internal.hs
in the warp
package.
@kazu-yamamoto Could you take a look at the new commit? I'm hoping I understood you correctly.
Yes. That is exactly what I suggested.
May I squash two commits into one?
@kazu-yamamoto sure, feel free to squash.
Sorry for the delay. I squashed them and removed Imports
. If you like this, I will release a new version.
@kazu-yamamoto I'll close this ticket then. Thanks! A release whenever you get a chance would be great. It'll let me devendor the fast-logger
package in my projects.
A new version has been released.
This closes #184 by moving all
other-modules
modules to an exported Internal module. No guarantees are made for the stability of the Internal module tree.