kazu-yamamoto / logger

A fast logging system for Haskell
159 stars 68 forks source link

Move other-modules into internal modules #185

Closed MichaelXavier closed 4 years ago

MichaelXavier commented 4 years ago

This closes #184 by moving all other-modules modules to an exported Internal module. No guarantees are made for the stability of the Internal module tree.

MichaelXavier commented 4 years ago

@kazu-yamamoto Just to be clear, are you suggesting:

A) Keeping the existing internal modules in the Internal directory and then create an Internal.hs module above that that imports and reexports them so there's only one internal module to import throughout the code.

or

B) Remove the Internal directory and merge all of the internal modules into one Internal.hs?

Personally I'm more in favor of A. Despite those modules being internal, they were presumably broken up originally for a reason, like being easier to reason about and work on, so I don't see why we shouldn't preserve that.

kazu-yamamoto commented 4 years ago

What I said is:

C) Sorry, but rework should start the current master. Adding a Internal.hs file which imports necessary stuffs and exports them. And add it to exposed-module: in the cabal file.

Please refer to Internal.hs in the warp package.

MichaelXavier commented 4 years ago

@kazu-yamamoto Could you take a look at the new commit? I'm hoping I understood you correctly.

kazu-yamamoto commented 4 years ago

Yes. That is exactly what I suggested.

kazu-yamamoto commented 4 years ago

May I squash two commits into one?

MichaelXavier commented 4 years ago

@kazu-yamamoto sure, feel free to squash.

kazu-yamamoto commented 4 years ago

Sorry for the delay. I squashed them and removed Imports. If you like this, I will release a new version.

MichaelXavier commented 4 years ago

@kazu-yamamoto I'll close this ticket then. Thanks! A release whenever you get a chance would be great. It'll let me devendor the fast-logger package in my projects.

kazu-yamamoto commented 4 years ago

A new version has been released.