kazu-yamamoto / logger

A fast logging system for Haskell
159 stars 68 forks source link

Support bytestring-0.11 #192

Closed Bodigrim closed 3 years ago

kazu-yamamoto commented 3 years ago

@Bodigrim The next is this library. Should I add base >= 4.9 to all metadata on Hackage?

Bodigrim commented 3 years ago

We need somehow avoid an unbuildable combination of base-4.8 and bytestring-0.11. I'd say that revising with bytestring < 0.11 is less controversial than with base >= 4.9, but whatever floats your boat. If you are reluctant to make a new release, you can, for instance, revise everything except logger-3.0.2 with bytestring < 0.11, but revise logger-3.0.2 with base >= 4.9.

kazu-yamamoto commented 3 years ago

I will do anything to help users if I'm convinced. :-) Does the follow work well?

Bodigrim commented 3 years ago

Yes, sounds good. You probably do not need to revise existing releases of wai-logger: once fast-logger has necessary bounds in place, wai-logger is protected from unbuildable configurations as well.

kazu-yamamoto commented 3 years ago

@Bodigrim Done for fast-logger. Please check. If OK, the next turn is http2.

Bodigrim commented 3 years ago

All good, thanks!