kazu-yamamoto / logger

A fast logging system for Haskell
159 stars 68 forks source link

fast-logger: Breaking API change in minor version bump #194

Closed snoyberg closed 3 years ago

snoyberg commented 3 years ago

3.0.3:

newFileLoggerSet :: BufSize -> FilePath -> IO LoggerSet

3.0.4

newFileLoggerSet :: BufSize -> Maybe Int -> FilePath -> IO LoggerSet

Discovered with a Stackage build, where downstream packages (tinylog and logging) were broken.

kazu-yamamoto commented 3 years ago

I categorized that System.Log.FastLogger.LoggerSet is a kind of internal modules. But if this is a real problem, I will recover the backward compatibility soon.

snoyberg commented 3 years ago

For now, I've opened up downstream issues:

I've also blocked fast-logger-3.0.4 from Stackage until downstream packages resolve the issue. There's no immediate problem for Stackage, so it's your decision on whether to make a change for the downstream packages.

kazu-yamamoto commented 3 years ago

Fixed in v3.0.5. 3.0.4 is deprecated.

snoyberg commented 3 years ago

Awesome, thanks!