search

kazu-yamamoto / logger

A fast logging system for Haskell
159 stars 68 forks source link

Export newFDLoggerSet #75

Open ocharles opened 8 years ago

ocharles commented 8 years ago

Is there any reason to have this private?

kazu-yamamoto commented 8 years ago

It depends on FD. I don't know that it is a good thing to export FD or not.

ocharles commented 8 years ago

In fact, I'd say just export LoggerSet. Right now I just wanted to create my own, but I'm completely stuck.

kazu-yamamoto commented 8 years ago

I'm OK to create the Internal module and export something in it. Is LoggerSet(..) enough for you?

ocharles commented 8 years ago

Sounds good, it might be worth putting LogStr in there too. I don't think there is really much benefit preventing people constructing these by hand if they so desire too (but keeping the constructors out of the main documentation sounds good).

kazu-yamamoto commented 8 years ago

If you want to create System.Log.FastLogger.Internal by yourself, please do it and send me a pull request. If not, it will do it.