search

kazu-yamamoto / logger

A fast logging system for Haskell
159 stars 68 forks source link

Helper functions for logging `Show a => a` values #77

Closed bitemyapp closed 8 years ago

bitemyapp commented 8 years ago

Thank you for the nice logging library! I use it a lot :)

screenshot from 2016-02-01 20-04-19

I end up writing this a lot. Would you be open to $log*T and $log*TS variants of the log functions which have the type:

$logDebugT :: (Show a, MonadLogger m) => a -> m ()

Instead of:

$logDebug :: MonadLogger m => Text -> m ()

If this is something you're willing to do, let me know and I will PR it. I'm not stuck on the naming either.

snoyberg commented 8 years ago

I'm down with it. I'm not in love with the T suffix, but also don't have any better ideas.

On Tue, Feb 2, 2016 at 4:06 AM, Chris Allen notifications@github.com wrote:

[image: screenshot from 2016-02-01 20-04-19] https://cloud.githubusercontent.com/assets/320177/12737539/01a8cc50-c91f-11e5-8aac-5d40849712c4.png

I end up writing this a lot. Would you be open to $log_T and $log_TS variants of the log functions which have the type:

$logDebugT :: (Show a, MonadLogger m) => a -> m ()

Instead of:

$logDebug :: MonadLogger m => Text -> m ()

If this is something you're willing to do, let me know and I will PR it. I'm not stuck on the naming either.

— Reply to this email directly or view it on GitHub https://github.com/kazu-yamamoto/logger/issues/77.

bitemyapp commented 8 years ago

@snoyberg would've used S if it hadn't been taken, for "Showable". Could use C for convert. Perhaps SH for SHow? Anyhoodle, I'll get the PR together and we can discuss there.

Thank you!

snoyberg commented 8 years ago

I like SH :)

On Tue, Feb 2, 2016 at 11:56 PM, Chris Allen notifications@github.com wrote:

@snoyberg https://github.com/snoyberg would've used S if it hadn't been taken, for "Showable". Could use C for convert. Perhaps SH for SHow? Anyhoodle, I'll get the PR together and we can discuss there.

Thank you!

— Reply to this email directly or view it on GitHub https://github.com/kazu-yamamoto/logger/issues/77#issuecomment-178847439 .

snoyberg commented 8 years ago

Resolved by #78