search

kazu-yamamoto / logger

A fast logging system for Haskell
159 stars 68 forks source link

add FastLogger and related helpers #85

Closed winterland1989 closed 8 years ago

winterland1989 commented 8 years ago

This is the first step to solve #84, The higher level api then can be used to add runFastLoggerLoggingT to monad-logger.

One thing i'm not sure is that i have copied Date.hs from wai-logger to get cached formatted time, i'm not sure i should do this or update it in date-cache and add it as a dependency.

winterland1989 commented 8 years ago

@kazu-yamamoto Please review : )

winterland1989 commented 8 years ago

Sorry for the commit noise, i didn't expect wai-logger will break if i export LogType from fast-logger, which i should. Now everything should be fine. If these changes are ok to you, i will process send pr to monad-logger, then we can bump version together.

kazu-yamamoto commented 8 years ago

The quality seems good to me. So, I have merged.

kazu-yamamoto commented 8 years ago

After releasing fast-logger 2.4.4, I noticed that this version breaks backward compatibility from the wai-logger point of view. The signature of LogFile is changed. I would suggest:

s/LogFile/LogFileNoRotate/ s/LogFileAutoRotate/LogFile/

kazu-yamamoto commented 8 years ago

I made fast-logger-2.4.4 deprecated.

winterland1989 commented 8 years ago

I'm just about to tell you this, and the with... version misuse bracket also, i'm working on a new pr.

kazu-yamamoto commented 8 years ago

Thanks.