Closed winterland1989 closed 6 years ago
@snoyberg I bumped version of fast-logger and restrict some exports, if it's ok to you, then please release a new version of monad-logger.
Any input on this @snoyberg ?
I hadn't realized this was ready for review now, I'll get to it later today.
Thanks!
@winterland1989 any updates on this PR?
It's quite a long time since this patch got sent, let @snoyberg judge on this. BTW, can you help to review this patch @qrilka?
The last comment I made was:
https://github.com/kazu-yamamoto/logger/pull/87/files#r60173460
It appears that the CPP code is still present.
OK, i'll try pick it up.
What's the status of the PR?
Hi @snoyberg I am also interested in this PR. Thanks!
Celebrating a year of waiting for this PR to move forward! :)
No need to wait. Feel free to update with the missing changes.
On Sun, Apr 1, 2018, 4:24 PM Alexey Raga notifications@github.com wrote:
Celebrating a year of waiting for this PR to move forward! :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kazu-yamamoto/logger/pull/87#issuecomment-377786650, or mute the thread https://github.com/notifications/unsubscribe-auth/AADBB8e30wOA0nBOw_uAUFAM1WMdo79Pks5tkNTxgaJpZM4IHKYg .
The new repo of monad-logger
is https://github.com/snoyberg/monad-logger
I would like to close this.
@snoyberg This patch make
MonadLogger
more useful with helpers to runLoggingT
withFastLogger/TimedFastLogger
. see #85 and #86. please review and make a release : )