Closed erikd closed 8 years ago
I just opened a PR to fix it on yesod-core: https://github.com/yesodweb/yesod/pull/1215
This does look like a regression in wai-logger. @kazu-yamamoto any objection to releasing a new version of wai-logger that re-adds that type synonym?
Pinging @winterland1989
I have no objections. I believed that wai-logger 2.2.6 is backward-compatible but it is not. So, we need to fix it.
OK, i'll do it.
@winterland1989 I'm working. :-)
@winterland1989 @snoyberg Please check the patch above.
Please proceed, i have another issue here, the clean up action here and here really should not be a no-op, it should be rmLoggerSet lgrset too, because rmLoggerSet will ensure flush in face of exceptions. can you fix that too?
@winterland1989 Can you write a test case to demonstrate the issue?
LGTM
It should solve the back-compatible issue. i haven't got an idea to add test to fast-logger, but i'll try.
I have released wai-logger v2.2.7.
@snoyberg BTW, do you know any tools to confirm backward compatibility of packages? I should use such tools before releasing.
@kazu-yamamoto I don't know of any tools, but you can use http://packdeps.haskellers.com/reverse to find the reverse dependencies of your package, set up a cabal sandbox, cabal sandbox add-source <your package>
and then cabal install
all the reverse dependencies into the sandbox.
Any breakage due to changes in your package will reveal themselves.
Yeah, that's one way. But I want to have tools to just compare exports of two versions of a package.
Sorry, I'm unaware of any tooling.
On Tue, Apr 19, 2016, 4:47 AM Kazu Yamamoto notifications@github.com wrote:
Yeah, that's one way. But I want to have tools to just compare exports of two versions of a package.
— You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/kazu-yamamoto/logger/issues/90#issuecomment-211677952
I think we really should bump the minor version if we want to be sure no large breakage happening.
Afaiac its fixed with the release of 2.2.7.
@winterland1989 What we should do is try to maintain backward compatibility as much as possible and bump minor versions. We bump the major versions if we break backward compatibility. In this case, we need strong/reasonable reasons to break backward compatibility.
I'm currently working on getting Yesod working for ghc-8.0 which is pretty close to being formally released.
Building the git version of
yesod-core
against the git version ofwai-logger
I get:Should that be fixed in
yesod-core
orwai-logger
?