search

kazu-yamamoto / logger

A fast logging system for Haskell
159 stars 68 forks source link

Callstack based logging #94

Closed alexbiehl closed 8 years ago

alexbiehl commented 8 years ago

@snoyberg as discussed in #93.

I haven't written comments on the functions. Lets see if you like it first.

snoyberg commented 8 years ago

LGTM! 👍

alexbiehl commented 8 years ago

I added some comments and squashed the commits.

snoyberg commented 8 years ago

This looks good. I've asked some colleagues to review as well, since others on my team have more CallStack experience than I do. I'll merge tomorrow unless I hear an objection. Thank you!

snoyberg commented 8 years ago

Thanks!

gregwebs commented 7 years ago

This seems to be missing the ability to use a section parameter. The located-monad-logger package exports functions for this.