export defaultLoc and logWithoutLoc

kazu-yamamoto / logger

A fast logging system for Haskell

159 stars 68 forks source link

export defaultLoc and logWithoutLoc #99

Closed Philonous closed 7 years ago

Philonous commented 8 years ago

They are useful for defining custom log functions where the log level is passed as a parameter rather than by choosing the respective function.

snoyberg commented 8 years ago

No objection, but can you add the following:

Minor version bump
Note in the ChangeLog
Haddocks for each of these newly exposed identifiers, including a @since comment with the new version

epsilonhalbe commented 7 years ago

I don't know why this PR didn't get any attention after @snoyberg replied - if there are no objections I will add the version bump and so on this evening/night and update the PR.

snoyberg commented 7 years ago

Sounds great, thanks! I'll hold off on releasing your other change, so this can be included in the same version bump you already submitted. Thank you!

epsilonhalbe commented 7 years ago

@snoyberg I think with PR #133 this can be closed as well.

snoyberg commented 7 years ago

Yup, thanks!