kazu-yamamoto / pgpdump

A PGP packet visualizer
http://www.mew.org/~kazu/proj/pgpdump/
BSD 3-Clause "New" or "Revised" License
174 stars 33 forks source link

should dump notation names (and not hex values) even if the value is not human readable #1

Closed ghostbar closed 14 years ago

ghostbar commented 14 years ago

I will copy here the report for Debian located on http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=464572 :

8<-------

The RFC4880 states, that names are always UTF-8 encoded strings, so they are always "readable", while values are not. Thus, I think that names should be dumped as strings, while the readability should only be examined while dumping the value.

Here is the patch for this change: --- subfunc.c.orig 2008-02-07 15:39:06.996720105 +0100 +++ subfunc.c 2008-02-07 15:39:18.547170952 +0100 @@ -163,10 +163,7 @@ vlen = Getc() * 256; vlen += Getc(); printf("\t\tName - ");

------->8

Hoping to hear soon of you :-) Regards

kazu-yamamoto commented 14 years ago

I'm now on vacation. I will consider this after the vacation.

kazu-yamamoto commented 14 years ago

I have merged this patch and released pgpdump 0.27. http://www.mew.org/~kazu/proj/pgpdump/en/

ghostbar commented 14 years ago

Thank you :-)